Incremental code modernization for (future) Python 3 port #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeLametta
force-pushed
the
python3
branch
2 times, most recently
from
3c716df
to
97ae350
Compare
|
I'd like to merge this PR to master: time will tell if it breaks something... 🤣 |
|
44ece38 introduces many lines with superflous braces like print((...)), where print already was used as a function. Did you do the conversion using a script? |
|
Oh, sorry, I hadn't noticed 0f67bc4. |
JoeLametta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP.
I'm trying to introduce only incremental changes which can be merged right now because they retain backward compatibility with Python 2 (but explicitly target Python 3). The aim is to simplify the porting effort that will take place after milestone 1.0 has been reached.