Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle FreeDB server errors gracefully #304

Merged
merged 3 commits into from
Oct 6, 2018
Merged

Handle FreeDB server errors gracefully #304

merged 3 commits into from
Oct 6, 2018

Commits on Oct 5, 2018

  1. handle FreeDB server errors gracefully 

    In my repeated tests, I ended up upsetting freedb.org, which started
issuing 502 errors. Those errors are not correctly caught by the
program which just crashes with a backtrace. Instead, we handle those
like any other API error, which can already be generated by
perform_lookup (but not handled).

The visible result for the user is that the CD is simply not found on
FreeDB, an acceptable compromise, in my opinion.

Closes: whipper-team#206
    @anarcat
    anarcat committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    7a20d81 View commit details
    Browse the repository at this point in the history

  2. harmonize an error message with other warnings 

    ... which are all capitalized.
    @anarcat
    anarcat committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    d2581ab View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2018

  1. Merge branch 'master' into freedb-catch

    @JoeLametta
    JoeLametta authored Oct 6, 2018
    Configuration menu
    Copy the full SHA
    3f7e1f0 View commit details
    Browse the repository at this point in the history