README.md: Fix disc_template example #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change disc_template and track_template example to avoid ugly KeyError while ripping. As wisely recommended by @RecursiveForest (thanks for that!) here: #279 (comment)
|
Thanks for the pull request, unfortunately this has been already fixed in #322 (which is going to be merged into master after we tag next whipper version). 😉 |
No problem! I'd change that for "fortunately" 😉 By the way, thank you very, very much for such a cool piece of software!! 👍 |
Oops...
I'm glad you like it: this is the result of many hours of personal development and great external contributions (CREDITS). 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that users don't need to google the KeyError to find @RecursiveForest's wise comment here:
#279 (comment)
😄