Use eject value of the class again #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorgobacka
force-pushed
the
perform_eject
branch
from
e330c57 to
3abd7ee
Compare
gorgobacka
changed the title
gorgobacka
force-pushed
the
perform_eject
branch
2 times, most recently
from
9a33b1e to
4a361b2
Compare
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
|
Merged, thanks! (I've fixed the PEP-8 warning) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
self.ejectwas used before #93 to decide if the disc should be ejected.This PR introduces this functionality again.
In correspondence to #392, the disc will still be ejected when the parameter
--ejectis set toalwaysbut not if--ejectis set tosuccessduringwhipper cd info.(Fixes: comment in #375)