extern.task: replace GLib event loop with asyncio event loop #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bradley Walters <oss@walters.app>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Bradley Walters <oss@walters.app>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This program is awesome.
This change works towards #5 by replacing the GLib MainLoop that backs
task.pywithasyncio's event loop. The interfaces are extremely similar and this removes a big dependency.I'm not sure what should be done about #5 after this given that quite a bit of whipper code uses the
Taskinterface. Maybetask.pyandasyncsub.pycan just be merged intowhipper/commonand later refactored?I tested this by going through the drive setup process from scratch (
whipper drive analyzeandwhipper offset find), ripping an album, then runningwhipper image verify. I ensured progress calculation worked and no commands got stuck.