Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration option to pass extra args to flac encode #587

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kevmitch
Copy link

@kevmitch kevmitch commented Feb 4, 2023

Add an argument to the whipper cd rip comand that can be provided on the command line or in the whipper.cd.rip section of the config file.

It is retrieved inside the _ripIfNotRipped() private function, split into a list and passed down through to program/flac.py, which actually calls the flac binary.

Add debug logging to that function so the actual command shows up in the debug log.

Add a unittest to ensure that arguments passed to flac.encode() work as expected.

Tested ripping a disc with --extra-flac-encode-args="--best -e --no-padding" from both the command line and config file as well as with the default empty value.

Signed-off-by: Kevin Mitchell kevmitch@gmail.com

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖 Thanks for opening your first pull request here! 💖

Add an argument to the whipper cd rip comand that can be provided on the
command line or in the whipper.cd.rip section of the config file.

It is retrieved inside the _ripIfNotRipped() private function, split
into a list and passed down through to program/flac.py, which actually
calls the flac binary.

Add debug logging to that function so the actual command shows up in the
debug log.

Add a unittest to ensure that arguments passed to flac.encode() work as
expected.

Tested ripping a disc with --extra-flac-encode-args="--best -e
--no-padding" from both the command line and config file as well as with
the default empty value.

Signed-off-by: Kevin Mitchell <kevmitch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant