Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups after merging ACI/PNI #298

Merged
merged 5 commits into from
Apr 13, 2024
Merged

Various cleanups after merging ACI/PNI #298

merged 5 commits into from
Apr 13, 2024

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Apr 2, 2024 •
edited
Loading

Various small changes I did as part of whisperfish/presage#245:

  • Use enum variants in a bunch of errors instead of static strings
  • Rename VerifyAccountResponse::uuid to VerifyAccountResponse::aci for completion (but use a serde alias)
  • Other kleinigkeiten
  • Use IdentityKey in some places where PublicKey was used before (and change the relevant serde modules)

@gferon gferon marked this pull request as ready for review April 12, 2024 14:03
@gferon gferon requested a review from rubdos April 12, 2024 14:03
rubdos
rubdos reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks rather good to me! :)

libsignal-service/src/pre_keys.rs Outdated Show resolved Hide resolved
@gferon gferon enabled auto-merge (squash) April 13, 2024 08:21
@rubdos
Copy link
Member

rubdos commented Apr 13, 2024

Cool, feel free to merge this! :-)

rubdos
rubdos approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gferon gferon merged commit 26c036e into main Apr 13, 2024
16 of 19 checks passed
@gferon gferon deleted the small-cleanup3 branch April 13, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubdos rubdos rubdos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gferon @rubdos