Skip to content

Commit

Permalink
Link secondary devices as primary device
Browse files Browse the repository at this point in the history
  • Loading branch information
Schmiddiii committed Nov 18, 2023
1 parent 46f6226 commit 18d83a6
Show file tree
Hide file tree
Showing 3 changed files with 67 additions and 3 deletions.
4 changes: 3 additions & 1 deletion presage-cli/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,9 @@ async fn run<S: Store + 'static>(subcommand: Cmd, config_store: S) -> anyhow::Re
async move {
match provisioning_link_rx.await {
Ok(url) => {
qr2term::print_qr(url.to_string()).expect("failed to render qrcode")
println!("Please scan in the QR code:");
qr2term::print_qr(url.to_string()).expect("failed to render qrcode");
println!("Alternatively, use the URL: {}", url);
}
Err(e) => log::error!("Error linking device: {e}"),
}
Expand Down
4 changes: 4 additions & 0 deletions presage/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ pub enum Error<S: std::error::Error> {
RequestingCodeForbidden(libsignal_service::push_service::RegistrationSessionMetadataResponse),
#[error("Unverified registration session (i.e. wrong verification code)")]
UnverifiedRegistrationSession,
#[error("Failed to link secondary device")]
ServiceLinkError(#[from] libsignal_service::LinkError),
#[error("An operation was requested that requires the registration to be primary, but it was only secondary")]
NotPrimaryDevice,
}

impl<S: StoreError> From<S> for Error<S> {
Expand Down
62 changes: 60 additions & 2 deletions presage/src/manager/registered.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ use libsignal_service::protocol::SenderCertificate;
use libsignal_service::protocol::{PrivateKey, PublicKey};
use libsignal_service::provisioning::generate_registration_id;
use libsignal_service::push_service::{
AccountAttributes, DeviceCapabilities, PushService, ServiceError, ServiceIds, WhoAmIResponse,
DEFAULT_DEVICE_ID,
AccountAttributes, DeviceCapabilities, DeviceInfo, PushService, ServiceError, ServiceIds,
WhoAmIResponse, DEFAULT_DEVICE_ID,
};
use libsignal_service::receiver::MessageReceiver;
use libsignal_service::sender::{AttachmentSpec, AttachmentUploadError};
Expand All @@ -40,6 +40,7 @@ use rand::rngs::StdRng;
use rand::SeedableRng;
use serde::{Deserialize, Serialize};
use tokio::sync::Mutex;
use url::Url;

use crate::cache::CacheCell;
use crate::serde::serde_profile_key;
Expand All @@ -49,6 +50,12 @@ use crate::{Error, Manager};
type ServiceCipher<S> = cipher::ServiceCipher<S, StdRng>;
type MessageSender<S> = libsignal_service::prelude::MessageSender<HyperPushService, S, StdRng>;

#[derive(Clone, Debug, PartialEq, Eq)]
pub enum RegistrationType {
Primary,
Secondary,
}

/// Manager state when the client is registered and can send and receive messages from Signal
#[derive(Clone)]
pub struct Registered {
Expand Down Expand Up @@ -880,6 +887,57 @@ impl<S: Store> Manager<S, Registered> {
}
}

/// Returns how this client was registered, either as a primary or secondary device.
pub fn registration_type(&self) -> RegistrationType {
if self.state.data.device_name.is_some() {
RegistrationType::Secondary
} else {
RegistrationType::Primary
}
}

/// As a primary device, link a secondary device.
pub async fn link_secondary(&self, secondary: Url) -> Result<(), Error<S::Error>> {
// XXX: What happens if secondary device? Possible to use static typing to make this method call impossible in that case?
if self.registration_type() != RegistrationType::Primary {
return Err(Error::NotPrimaryDevice);
}

let credentials = self.credentials().ok_or(Error::NotYetRegisteredError)?;
let mut account_manager = AccountManager::new(
self.identified_push_service(),
Some(self.state.data.profile_key),
);
let store = self.store();

account_manager
.link_device(secondary, store, credentials)
.await?;
Ok(())
}

/// As a primary device, unlink a secondary device.
pub async fn unlink_secondary(&self, device_id: i64) -> Result<(), Error<S::Error>> {
// XXX: What happens if secondary device? Possible to use static typing to make this method call impossible in that case?
if self.registration_type() != RegistrationType::Primary {
return Err(Error::NotPrimaryDevice);
}
self.identified_push_service()
.unlink_device(device_id)
.await?;
Ok(())
}

/// As a primary device, list all the devices.
// XXX: Also shows the current device?
pub async fn linked_devices(&self) -> Result<Vec<DeviceInfo>, Error<S::Error>> {
// XXX: What happens if secondary device? Possible to use static typing to make this method call impossible in that case?
if self.registration_type() != RegistrationType::Primary {
return Err(Error::<S::Error>::NotPrimaryDevice);
}
Ok(self.identified_push_service().devices().await?)
}

/// Deprecated methods

/// Get a single contact by its UUID
Expand Down

0 comments on commit 18d83a6

Please sign in to comment.