Reconnect websockets lazily on usage #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When identified or unidentified websocket is used, it is checked whether it is closed, and in that case it is reconnected. This is less powerful to auto-reconnecting websockets, because the messages stream would not be interrupted. But this is a very simple implementation which works quite well on application level.
|
Nice, thanks! |
boxdot
added a commit
to boxdot/gurk-rs
that referenced
this pull request
Dec 19, 2023
The implementation is done in <whisperfish/presage#222>
boxdot
added a commit
to boxdot/gurk-rs
that referenced
this pull request
Dec 19, 2023
The implementation is done in <whisperfish/presage#222>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When identified or unidentified websocket is used, it is checked whether it is closed, and in that case it is reconnected. This is less powerful than an auto-reconnecting websocket, because the messages stream is interrupted. But this is a very simple implementation which works quite well on application level.