Use Send async_trait for SessionStoreExt #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, presage does not build due to the recent changes to
libsignal-service. This quick change allows the crate to compile.Surprisingly, out of the five different instances of
#[async_trait(?Send)], this one is the only one that can actually be changed to#[async_trait]. All the others will fail to compile due to the_ctxpointer in the upstreamlibsignal-client. But forSessionStoreExtspecifically, the change compiles out of the box. This works out quite nicely, as we can keep things building even while we are waiting on signalapp/libsignal#297.