Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return unparseable country code as error instead of silent failure #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/phone_number.rs
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,12 @@ impl<'a> Country<'a> {
self.0.code.value()
}

pub fn id(&self) -> Option<country::Id> {
self.0.metadata(&DATABASE).and_then(|m| m.id().parse().ok())
pub fn id(&self) -> Result<Option<country::Id>, crate::error::Parse> {
self.0
.metadata(&DATABASE)
.map(|m| m.id().parse())
.transpose()
.map_err(|_e| crate::error::Parse::InvalidCountryCode)
}
}

Expand Down Expand Up @@ -295,7 +299,10 @@ mod test {
#[case] country: Option<country::Id>,
#[case] _type: Type,
) -> anyhow::Result<()> {
assert_eq!(country, number.country().id());
// Flatten the error into an Option.
// XXX: We can't currently distinguish an error case from an unavailable case, given the
// current phone number list in rstest above.
assert_eq!(country, number.country().id().ok().flatten());

Ok(())
}
Expand Down
Loading