Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADC channel sanity check not working? #3

Closed
MrZANE42 opened this issue Dec 12, 2016 · 1 comment
Closed

ADC channel sanity check not working? #3

MrZANE42 opened this issue Dec 12, 2016 · 1 comment

Comments

@MrZANE42
Copy link

First of: Excuse me if I'm wrong I haven't tried the code I just happened to see something strang while looking through the code in the repo.
In Lua-RTOS-ESP32/components/lua_rtos/drivers/adc.c it's written (in a couple of places):
if (!((1 << channel) && CPU_ADC_ALL))

I'm quite sure that that should be written as so:
if (!((1 << channel) & CPU_ADC_ALL))

That is: & instead of &&
jolivepetrus added a commit that referenced this issue Dec 12, 2016
@jolivepetrus
ADC driver
edcfb57 
* Bug resolved in channel sanity checks (issue #3)
@jolivepetrus
Copy link
Contributor

Thanks for reporting this. This have been solved in edcfb57.

@JanHouwers JanHouwers mentioned this issue May 1, 2017
Closed
jolivepetrus pushed a commit that referenced this issue Jun 7, 2017
@the0ne
Merge pull request #3 from whitecatboard/the0ne-wifi-fix
4cd1e55 
HTTP server, added a mechanism in Net driver for register a callback into the event loop + lua pages preprocessor
@elsbiet elsbiet mentioned this issue May 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrZANE42 @jolivepetrus