Emit an event in Nova whenever the order of a flexible content group changes #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have moved around Compile assets for production
…Nova-TinyMCE), hence the editor settings are now retrieved from a global variable
…t, update packages
… have moved around Compile assets for production
…Nova-TinyMCE), hence the editor settings are now retrieved from a global variable
…t, update packages
# Conflicts: # src/Layouts/Layout.php # yarn.lock
… have moved around Compile assets for production
…Nova-TinyMCE), hence the editor settings are now retrieved from a global variable
…t, update packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to accommodate Nova TinyMCE, which is not officially supported by this package. It emits the event 'flexible-content-order-changed' so that other packages, such as the Nova TinyMCE package, can respond accordingly and re-render TinyMCE for example.
I'm submitting this PR as a response to #156 (comment), but I'd love to hear what you guys think about this solution now.