Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #70

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Update README.md #70

merged 1 commit into from
Jul 7, 2021

Conversation

marcofavorito
Copy link
Member

Proposed changes

Fix bug in bash wrapper for the Lydia Docker image. The formula argument was not expanded properly due to missing quotes between $@.

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

Fix bug in bash wrapper for the Lydia Docker image. The formula argument was not expanded properly due to missing quotes between `$@`.
@marcofavorito marcofavorito requested a review from cipollone July 7, 2021 16:15
@cipollone
Copy link

Tested and working

@marcofavorito marcofavorito merged commit 696065d into main Jul 7, 2021
@marcofavorito marcofavorito deleted the marcofavorito-patch-1 branch July 7, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants