Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultTemplate uses "previous_message" rather than "prev_message" #219

Closed
sampart opened this issue Jan 10, 2017 · 3 comments
Closed

DefaultTemplate uses "previous_message" rather than "prev_message" #219

sampart opened this issue Jan 10, 2017 · 3 comments

Comments

@sampart
Copy link
Collaborator

sampart commented Jan 10, 2017 •
edited
Loading

The DefaultTemplate uses previous_message as the option name, but the docs and the other templates (including the TwitterBootstrapTemplate) use prev_message. We should update the default to be prev_message too.
@sampart sampart mentioned this issue Jan 10, 2017
Merged
@sampart
Copy link
Collaborator Author

sampart commented Jan 10, 2017

https://github.com/whiteoctober/Pagerfanta/search?utf8=%E2%9C%93&q=prev_message
https://github.com/whiteoctober/Pagerfanta/blob/master/README.md#defaultview

@the94air
Copy link

the94air commented Feb 3, 2017

That problem is also in the DefaultTemplate prev_message instead of previous_message in Readme.md file

cezzre pushed a commit that referenced this issue May 22, 2017
Fixes #219
0310f52
@cezzre cezzre mentioned this issue May 22, 2017
Merged
@sampart sampart changed the title TwitterBootstrapTemplate uses "prev_message" rather than "previous_message" DefaultTemplate uses "previous_message" rather than "prev_message" Apr 17, 2018
@sampart
Copy link
Collaborator Author

sampart commented Apr 17, 2018

For clarity, this has been fixed by #230.

@sampart sampart mentioned this issue Apr 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sampart @the94air