Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis updates #236

Merged
merged 3 commits into from
Aug 8, 2017
Merged

Travis updates #236

merged 3 commits into from
Aug 8, 2017

Conversation

sampart
Copy link
Collaborator

@sampart sampart commented Aug 8, 2017

  • Remove HHVM from Travis build (fixes Build failing on Travis #232)
  • Switch to Trusty (14.04) on Travis but keep 5.3 on Precise (12.04)
  • Test dev against PHP 5.6; 5.5 is EOL

olorton
olorton approved these changes Aug 8, 2017
View reviewed changes
Copy link
Contributor

@olorton olorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sampart sampart merged commit 2700705 into master Aug 8, 2017
@sampart sampart deleted the travis-updates branch August 8, 2017 08:39
stof
stof reviewed Aug 8, 2017
View reviewed changes
.travis.yml
# older releases
- php: 5.5
env: SOLARIUM_VERSION=2.* DOCTRINE_ORM_VERSION=2.3.*
# dev versions
- php: 5.5
- php: 5.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even test against 7.1 instead.

.travis.yml
php:
- 5.3
- 5.4
- 5.5
- 5.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.0 and 7.1 should be added

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment. I've raised #237 for this, as unfortunately it looks like some additional work will be required to add them in.

@Koc
Copy link

Koc commented Aug 8, 2017

What about adding travis cache for faster builds?

@sampart
Copy link
Collaborator Author

sampart commented Aug 8, 2017

@Koc How does your suggestion relate to your PR #184? Is the solution to update that?

@Koc
Copy link

Koc commented Aug 8, 2017 •
edited
Loading

It similar, but requires some changes

sudo: false

cache:
  directories:
- $HOME/.composer/cache

@sampart
Copy link
Collaborator Author

sampart commented Aug 8, 2017

Well, feel free to make a PR for the change if you'd like! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@olorton olorton olorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failing on Travis
4 participants
@sampart @Koc @stof @olorton