Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctrine dbal groupby #284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tugrul
Copy link

@tugrul tugrul commented Nov 18, 2019

Sample usecase:

$pager = new Pagerfanta(new DoctrineDbalAdapter($query, function (QueryBuilder $queryBuilder) {
    return $queryBuilder->getConnection()
        ->createQueryBuilder()
        ->select('COUNT(*) AS total')
        ->from('(' . $queryBuilder->getSQL()  . ')', 'QL')
        ->setMaxResults(1)
        ->setParameters($queryBuilder->getParameters());
}));

adapter members are able to be protected instead of private
there is no way to extend adapter and change behavior in other case
@sampart
Copy link
Collaborator

sampart commented Nov 18, 2019

See #169

@sampart
Copy link
Collaborator

sampart commented Nov 18, 2019

Thanks for this, @tugrul. I'm not able to test this, so please could you confirm what testing you've done? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants