- builder.rb: correctly handle ... forwarding to super with explicit block
#1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t block Upstream commit ruby/ruby@a850cd1 is specific to 3.3, previous versions already did not allow this. See https://bugs.ruby-lang.org/issues/20392 for a bit more info. But since the super node has has a different shape, it behaved unexpectedly in earlier ruby versions already. It allowed forwarding with zero and one arguments and failed for more. Now correctly rejects it as invalid syntax, except in Ruby 3.3, that fix has not been backported.
iliabylich
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1004
Upstream commit ruby/ruby@a850cd1 is specific to 3.3, previous versions already did not allow this.
See https://bugs.ruby-lang.org/issues/20392 for a bit more info.
But since the super node has has a different shape, it behaved unexpectedly in earlier ruby versions already.
It allowed forwarding with zero and one arguments and failed for more. Now it correctly rejects as invalid syntax, except in Ruby 3.3, that fix has not been backported.