Enforcing frozen string literals with pragma comment. #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
requested changes
Jan 4, 2018
| #! /usr/bin/env ruby | ||
| # coding: utf-8 | ||
| # frozen_string_literal: true | ||
| # warn_indent: true |
There was a problem hiding this comment.
Ah, I missed these unexpected changes - seems Pragmater got confused. I'll fix that up.
| @@ -27,8 +33,6 @@ def associate_locations(code) | |||
|
|
|||
| def test_associate | |||
| ast, associations = associate(<<-END) | |||
| #!/usr/bin/env ruby | |||
There was a problem hiding this comment.
You shouldn't remove these. They're testing the behavior of the comment associator, and this code is not ever run.
whitequark
approved these changes
Jan 4, 2018
|
Thanks for the PR! |
|
No worries - thanks for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly different take on #354 - instead of relying on dependencies to be frozen-string-literal friendly, this PR adds the pragma comment to all Ruby files, and then string literals are frozen for Ruby versions that support it.
This ensures the test suite can remain green while supporting frozen string literals, separate of whether dependencies do. If/when dependencies are all supporting frozen string literals, then perhaps the env flag (as noted in the Travis CI config in #354) can be set as well.