Optimize duplicate hash key warning #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces O(n^2) processing loop with a set. I benchmarked parsing a file with a single 5000 key hash to test this change's performance. Before: **Before** ```sh $ hyperfine --warmup 3 'bin/ruby-parse hash_bench.rb' Benchmark 1: bin/ruby-parse hash_bench.rb Time (mean ± σ): 2.678 s ± 0.029 s [User: 2.613 s, System: 0.061 s] Range (min … max): 2.636 s … 2.738 s 10 runs ``` **After** ```sh $ hyperfine --warmup 3 'bin/ruby-parse hash_bench.rb' Benchmark 1: bin/ruby-parse hash_bench.rb Time (mean ± σ): 421.3 ms ± 4.1 ms [User: 366.9 ms, System: 49.9 ms] Range (min … max): 414.8 ms … 426.1 ms 10 runs ``` - See whitequark#918
|
Thanks! Let me know if you need a release. |
|
Thanks for the fast review/merge!
I'm not personally in any rush--I just happened to be following the related issue and it seemed like a fun, targeted fix. |
|
Awesome effort @dgollahon! @iliabylich it'd be awesome to have a release, not urgent but some day. |
|
@prikha I've released |
This was referenced Apr 25, 2023
glebm
added a commit
to glebm/i18n-tasks
that referenced
this pull request
Apr 25, 2023
This is the first version which includes the fix (whitequark/parser#924) to a performance issue (whitequark/parser#918) first introduced in 3.0.3.0 (whitequark/parser@547d731) Fixes #407
glebm
added a commit
to glebm/i18n-tasks
that referenced
this pull request
Apr 25, 2023
This is the first version which includes the fix (whitequark/parser#924) to a performance issue (whitequark/parser#918) first introduced in 3.0.3.0 (whitequark/parser@547d731) Fixes #407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
$ hyperfine --warmup 3 'bin/ruby-parse hash_bench.rb' Benchmark 1: bin/ruby-parse hash_bench.rb Time (mean ± σ): 2.678 s ± 0.029 s [User: 2.613 s, System: 0.061 s] Range (min … max): 2.636 s … 2.738 s 10 runsAfter
$ hyperfine --warmup 3 'bin/ruby-parse hash_bench.rb' Benchmark 1: bin/ruby-parse hash_bench.rb Time (mean ± σ): 421.3 ms ± 4.1 ms [User: 366.9 ms, System: 49.9 ms] Range (min … max): 414.8 ms … 426.1 ms 10 runs