-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokenize text field in textFieldDidEndEditing #141
Conversation
@ricardopereira Please review this PR |
@rizwan95 Thank you for the PR! Could you had a description please explaining the reason of this change? So, the purpose of this PR is tokenize the text that is in the text field after the text field resigns its first responder status, right? |
|
@rizwan95 Ok, to avoid breaking the existing apps with WSTagsField, I would suggest to create a new Boolean property called |
@ricardopereira : Yes, that sounds right. So shall we do that modification? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments. Thank you.
@rizwan95 Yes please. |
@ricardopereira Your suggestion has been integrated :) |
@rizwan95 I don't see them. Did you pushed your changes? |
@ricardopereira Please check now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thanks
@ricardopereira that's awesome! |
strange, pod install on 5.3.1 does not have this property in the source. |
Update: when I specify the specific master branch `, :git => 'https://github.com/whitesmith/WSTagsField.git' in my Podfile, the changes are pulled up, might be an issue with this projects's cocoapods trunk versioning? |
@leojkwan This hasn't been released yet. I'll try to make a new version this week. Sorry for the inconvenience. |
Thanks @ricardopereira ! |
The purpose of this PR is tokenize the text that is in the text field after the text field resigns its first responder status.