Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 423 - Add coverage data to compare view #474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rishijain
Copy link
Contributor

Check list:

This fixes issue: #423
I noticed that we are not passing any coverage data and the default value of it being 0, it shows 0% against all the files for compare build view.

@rishijain rishijain changed the title add coverage data to compare view Issue 423 - Add coverage data to compare view Oct 19, 2023
@santhosh-fit
Copy link

@nunosilva800 could you review and merge this please? I am starting to use rubycritic and showing the correct coverage info on build/compare would be helpful.

Copy link
Collaborator

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishijain How does this work? I don't understand what's the goal of this PR.

I think it's a tricky problem to solve: To show the difference in coverage between two branches.

The main issue is this: People don't usually check in their coverage directory (so the coverage artifacts are going to be the same across two branches) which makes it very tricky to show a comparison of coverage data.

In order to show a useful comparison in coverage data, then we would have to rely on the user running the test suite in one branch, storing the coverage resultset artifact, then another, then store the new artifact, then run rubycritic and then compare this.

I'm inclined to not support this in the compare view for now... Thoughts?

PS. Sorry for the delay. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants