Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibilities with some column types #4

Conversation

lukasmasuch
Copy link

Describe your changes

This PR improves the compatibility related to some column types when serialized to parquet (instead of arrow). This includes:

  • Converts columns containing interval, period, set, tuple and datetime object types to string.
  • Uses the newer string type for better null support.
  • Converts all non-string column names to string
  • Uses column config to configure certain types correctly for editing: categorical, text, and boolean.
  • Auto converts date, time, and datetime object columns to pandas native datetime columns to support editing.
  • Support byte arrays as list input. Parquet interprets number lists as byte arrays.
  • Always lowercase the type name, parquet sometimes uses uppercase type names (e.g. Uint64) which are not detected correctly.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@whitphx
Copy link
Owner

whitphx commented Aug 22, 2023

Thank you very very much! I really appreciate your support and this PR filling the edge cases I couldn't cover 😸

@whitphx whitphx merged commit 0ca13f1 into whitphx:feature/1.24-bypass-arrow-with-parquet Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants