You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for submitting these changes. A couple of comments/questions:
According to the Z-Wave Device Class Specification (if I'm reading things correctly), a Portable Scene Controller devices has the following mandatory command classes in addition to the ones you've already included: "Association", "Scene Controller Configuration", "Manufacturer Specific" and "Scene Activation". Ideally, those should be added to the constructor (except for perhaps Association because that is not yet supported anywhere). Otherwise, some TODO comments in the code would be helpful to indicate that the command class is not yet fully implemented.
Are the "Central Scene" and "Battery" command classes implemented by all Portable Scene Controllers? If not, they shouldn't be added in the constructor of Portable Scene Controller or it could cause problems with portable scene controller devices that don't implement those command classes. They should only be included if the device interview indicates they are implemented by the device.
According to the Z-Wave Application Command Class Specification, the "Central Scene" command class has 3 different versions. Which one(s) specifically are you trying to support with this new code? The implementation needs to be explicit about the maximum supported version number and implement all relevant version behavior or it can cause problems with certain portable scene controller devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.