Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenGraph improvements #31

Open
1 of 3 tasks
straup opened this issue May 21, 2024 · 0 comments
Open
1 of 3 tasks

OpenGraph improvements #31

straup opened this issue May 21, 2024 · 0 comments
Labels
enhancement New feature or request opengraph templates

Comments

@straup
Copy link
Contributor

straup commented May 21, 2024 •
edited by thisisaaronland
Loading

  • Stop hard-coding request host in og:image properties (why doesn't req.URL.Host seem to work?)
  • Determine whether og:image actually supports SVG endpoints; if not use PNG (blocked on issue Add /png handler for ID records #30)
  • Add httpd.NewOpenGraph(req, title, desc, image) methof
@straup straup added enhancement New feature or request opengraph labels May 21, 2024
straup pushed a commit that referenced this issue May 23, 2024
issue #14 - working opensearch implementation; also add URIs.Abs func…
79e8ffc 
…tion which addresses hostname issues in issue #31
thisisaaronland added a commit that referenced this issue May 23, 2024
@thisisaaronland
Add OpenSearch description (#34)
9ef0541 
* issue #14 - wire in basic opensearch stuff, untested

* issue #14 - working opensearch implementation; also add URIs.Abs function which addresses hostname issues in issue #31

---------

Co-authored-by: thisisaaronland <thisisaaronland@localhost>
Co-authored-by: whosonfirst <whosonfirst@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request opengraph templates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@straup @thisisaaronland