Added handling hidden parameter in commands. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whwright
reviewed
Mar 1, 2023
click_command_tree.py
Outdated
| @@ -30,7 +30,8 @@ def _build_command_tree(click_command): | |||
|
|
|||
| if isinstance(click_command, click.core.Group): | |||
| for _, cmd in click_command.commands.items(): | |||
| wrapper.children.append(_build_command_tree(cmd)) | |||
| if not cmd.hidden: | |||
There was a problem hiding this comment.
It looks like the hidden attribute was added in v7, and I would like to keep this library as backwards compatible as possible. Could this also handle the case where this attribute is not there?
Suggested change
| if not cmd.hidden: | |
| if not getattr(cmd, "hidden", False): |
There was a problem hiding this comment.
Sure,
the offered solution was just proof of concept. Thank you for reply
|
Hi, |
I will make some time this weekend to get this release out |
|
Perfektní, thanks
Dne čt 2. 3. 2023 18:39 uživatel Harrison Wright ***@***.***>
napsal:
… Hi, the last one question :-) Do you have any plan / schedule to update
the click-tree with this hidden commands and get it on pypi.org ? Thanks
:-)
I will make some time this weekend to get this release out
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABS2LTDT55LFHZVTVS7AOUDW2DLNBANCNFSM6AAAAAAVKNKPBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@Gargy007 I released version 1.1.1 |
|
Hi,
thank you, I appreciate it.
Petr
pá 3. 3. 2023 v 15:07 odesílatel Harrison Wright ***@***.***>
napsal:
… @Gargy007 <https://github.com/Gargy007> I released version 1.1.1
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABS2LTHKLGSJ3BLAZOETLWTW2H3LFANCNFSM6AAAAAAVKNKPBQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8
Just check that code if it's OK for you. Thank you