Add "times played" slider filter #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super cool! Thank you for the addition 😁 -- I'll try to review and comment this weekend. From glancing at the code so far -- looks good and clean 🥇 |
|
Sorry didn't get to it this weekend 😅 |
|
Thank you @litelime 🎉 stellar work 🤩 |
c3cris
pushed a commit
to c3cris/Video-Hub-App
that referenced
this pull request
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order videos with 0 plays to show, min value needed to be set to -1.
So display pipe adds 1 to value to keep displayed label value 0+.
The effect is that left slider is inclusive, and right slider is exclusive to the actual number of times played.
I think it is still pretty straightforward to use though.
One thing I noticed is the view does not immediately update when the times played value goes outside the bounds of the filter.
EX: With the stars filter, if I am filtering for only 5 star videos, and I rate a video less than 5, it will immediately leave the view, would like to get that same behaviour here