Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quit menu item on macOS #653

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

martinriviere
Copy link
Contributor

Hi,

This fixes #652. I added the quit option in main menu, and current options are now in a separate Edit menu.
I also added productName property in package.json so Electron refers to it for the app name in the menus and everywhere using app.name (and no longer to the name property, which is in kebab case).

Thanks!

@whyboris
Copy link
Owner

whyboris commented May 3, 2021

Thank you so much!
And thanks for the productName improvement 😁
I'll try to find time this weekend to test it and merge it in 👍

@whyboris
Copy link
Owner

whyboris commented Jul 8, 2021

Thank you again @martinriviere for the improvement 🙇
Sorry it took so many months for me to get to it 😅 I was moving to a new house and just finally got back to VHA 🐌

@whyboris whyboris merged commit b6406c1 into whyboris:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please can we have a 'quit' option from top menu on Mac
2 participants