Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that settings are not properly saved when app is exiting #694

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix bug that settings are not properly saved when app is exiting #694

merged 1 commit into from
Feb 21, 2023

Conversation

CrendKing
Copy link
Contributor

Discussion at #675.

@whyboris
Copy link
Owner

whyboris commented Oct 6, 2021

Thank you again for your contribution 🙇
I've not forgotten - just haven't gotten back to VHA in a while 😓 (busy with life stuff 👌 )
I hope to find more time this winter (and hopefully earlier) 😅

@CrendKing
Copy link
Contributor Author

No problem.

@cal2195
Copy link
Collaborator

cal2195 commented Apr 24, 2022

This seems like a pretty important fix we should probably merge - logic from the bug is sound too. 🐛

@whyboris
Copy link
Owner

I intend to clean up the PR queue before releasing the next (bugfix) release 😅
Hoping to find time for it in the coming months 🤞

@whyboris
Copy link
Owner

ps - brief summary: I moved to a new state (in the US) and bought a house; it's been great fun doing house work (doing some electrical stuff, wood/drywall, etc; currently building a kitchen bought from IKEA but have to first upgrade the circuit breaker panel to a larger on and then run new electrical through the crawlspace).

tl;dr - have been super-eager to get back to VHA but have been busy 😅

@CrendKing CrendKing closed this by deleting the head repository Nov 10, 2022
@whyboris
Copy link
Owner

😓 sorry I've still not gotten back to serious VHA development this year -- this winter I'll get to it 🤞

Thank you again for your contribution 🙇

@whyboris whyboris reopened this Nov 10, 2022
@whyboris
Copy link
Owner

🤞 seems like it should work 😅
I'm eager to release -- so I'm 🚀 merging in 🤞

@whyboris whyboris merged commit 2950322 into whyboris:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants