-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #757 - Folder size indicator show "k" when over 1,000 #769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the contribution!
Would you have time and interest in updating the code to use a pipe
instead?
The main change would be to create a pipe
(see other pipes I have to see how they work) - move the code you have from component.ts
into the pipe, and finally use it in the template: {{ video.fileSizeDisplay | kpipe }}
🤔
I gave a talk about pipes if you'd like a quick intro: YouTube
I've added the Please let me know if there's anything else I need to do 🤝 https://hacktoberfest.com/participation/#maintainers As far as I can tell - this submission applies as a |
This PR will close #757 👍 |
Sure I will create a pipe.
|
@whyboris I created the pipe. I can rename it if you want. |
@jmdagenais looks awesome! Thank you for converting the code to a pipe 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great! I'll try to merge it in this week 🤝 -- I just want to test it locally just in case 👍
Will this PR count for Hacktoberfest?