-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added button to sort auto tags #774
Conversation
Thank you for the code contribution 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great -- looking forward to testing it locally 👍
Hello @whyboris :) did you find some time to test it locally? I can see, that it is still open, so i don't know if I should improve something or you haven't found the time for it yet. :) |
Sorry to leave you hanging. This weekend I ended up trying to finish up this project: |
I see, it´s fine, nevermind 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally - works beautifully 😍
Thank you for the careful work 🤝
: showAutoFileTags | ||
: showAutoFolderTags | ||
: tagViewUpdateHack) | ||
| autoTagSortPipe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than duplicating the block and adding the pipe here, a simpler solution would be to have the pipe accept a boolean for whether to filter the contents 😉
I tested locally and it works great, so I'll make this small change after merging 🤝
Thank you again @gabriel-kazimir for this code contribution 🙇 I made a small adjustment after your PR: deef6fa |
Button is in "Tags" section in "View setting". I also added a czech translation for it.