New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make everything dataset UDFs #117

Merged

jamie256 merged 23 commits into main from dev/richard/alldataset

Aug 9, 2023

Contributor

richard-rogers commented Aug 4, 2023

Use dataset UDFs instead of metric UDFs. Instead of matching on column type, just register for prompt & response columns.


          Make everything dataset UDFs

3bfe9be

richard-rogers requested review from andrewelizondo, FelipeAdachi and jamie256

August 4, 2023 19:28

richard-rogers and others added 5 commits

August 4, 2023 12:28


          Merge branch 'main' into dev/richard/alldataset

2ce8d28


          unit tests pass

de3fc1a


          Merge branch 'dev/richard/alldataset' of github.com:whylabs/langkit i…

18f0d25

…nto dev/richard/alldataset


          pre-commit


          load tests working

669f609

richard-rogers mentioned this pull request

load tests interfere with eachother #109

Closed

richard-rogers commented

View reviewed changes

langkit/textstat.py Outdated Show resolved Hide resolved

FelipeAdachi mentioned this pull request

Makes themes groups customizable #118

Merged

andrewelizondo suggested changes

View reviewed changes

Contributor

andrewelizondo left a comment

Few changes needed but otherwise looks good 👍 let's just make sure the output columns are consistent.

langkit/nlp_scores.py Outdated Show resolved Hide resolved

langkit/themes.py Outdated Show resolved Hide resolved

langkit/themes.py Outdated Show resolved Hide resolved


          list-driven teststat metrics

8e04d6e

FelipeAdachi reviewed

View reviewed changes

langkit/textstat.py Outdated Show resolved Hide resolved

richard-rogers added 2 commits

August 7, 2023 14:14


          textstat unit tests

50305ff


          review feedback

c98b05d

andrewelizondo reviewed

View reviewed changes

langkit/nlp_scores.py Outdated Show resolved Hide resolved

andrewelizondo reviewed

View reviewed changes

langkit/nlp_scores.py Outdated Show resolved Hide resolved

andrewelizondo reviewed

View reviewed changes

langkit/nlp_scores.py Outdated Show resolved Hide resolved

andrewelizondo reviewed

View reviewed changes

langkit/tests/test_nlp_scores.py Outdated Show resolved Hide resolved

jamie256 reviewed

View reviewed changes

langkit/nlp_scores.py Outdated Show resolved Hide resolved

jamie256 reviewed

View reviewed changes

langkit/nlp_scores.py Outdated Show resolved Hide resolved

jamie256 reviewed

View reviewed changes

langkit/nlp_scores.py Outdated Show resolved Hide resolved


          fix unit test

2919deb

richard-rogers commented

View reviewed changes

langkit/nlp_scores.py Outdated Show resolved Hide resolved

richard-rogers and others added 3 commits

August 7, 2023 14:27


          Update langkit/nlp_scores.py

e79379b


          Update langkit/nlp_scores.py

b9e2989

Co-authored-by: Jamie Broomall <88007022+jamie256@users.noreply.github.com>


          pre-commit

29fc23b

jamie256 reviewed

View reviewed changes

Collaborator

jamie256 left a comment

Some minor comments and typo fixes, I'm ok with the changes pending approval from the other reviewers.

langkit/topics.py Show resolved Hide resolved

langkit/topics.py Show resolved Hide resolved

jamie256 reviewed

View reviewed changes

langkit/textstat.py Show resolved Hide resolved

jamie256 reviewed

View reviewed changes

langkit/sentiment.py Outdated Show resolved Hide resolved

jamie256 reviewed

View reviewed changes

langkit/sentiment.py Outdated Show resolved Hide resolved

richard-rogers added 7 commits

August 8, 2023 12:15


          add sentiment unit test

be5d8da


          preserve sentiment_nltk() as a callable function

0aec919


          preserve original text stat names

c27af81


          pre-commit

2f8460b


          make sentiment a load test

9a64bbb


          sheesh...

6a946b5


          pre-commit

caf25ae

richard-rogers commented

View reviewed changes

langkit/textstat.py Outdated Show resolved Hide resolved

richard-rogers commented

View reviewed changes

langkit/themes.py Outdated Show resolved Hide resolved

richard-rogers commented

View reviewed changes

langkit/themes.py Outdated Show resolved Hide resolved

richard-rogers commented

View reviewed changes

langkit/toxicity.py Outdated Show resolved Hide resolved


          self-review

39150a4

richard-rogers commented

View reviewed changes

langkit/sentiment.py Outdated Show resolved Hide resolved

richard-rogers and others added 2 commits

August 8, 2023 13:25


          Update langkit/sentiment.py

a9f50a3


          pull toxicity out into callable/wrapper

e5cce3a

andrewelizondo approved these changes

View reviewed changes

Contributor

andrewelizondo left a comment

LGTM

richard-rogers commented

View reviewed changes

langkit/sentiment.py

+              @register_dataset_udf([_prompt], udf_name=f"{_prompt}.sentiment_nltk")
+              def prompt_sentiment(text):
+                  return [sentiment_nltk(t) for t in text[_prompt]]

Contributor Author

richard-rogers Aug 9, 2023

Suggested change

      
                return [sentiment_nltk(t) for t in text[_prompt]]
          
                return list(map(sentiment_nltk, text[_prompt]))

jamie256 merged commit 3129051 into main

12 checks passed

jamie256 deleted the dev/richard/alldataset branch

August 9, 2023 16:49

jamie256 mentioned this pull request

update udfs to produce columns and sit under names #113

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet