Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rolling logger schema #318

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix rolling logger schema #318

merged 1 commit into from
Nov 6, 2024

Conversation

jamie256
Copy link
Collaborator

@jamie256 jamie256 commented Nov 6, 2024

Fix the rolling logger helper class to support:

  • passing in a custom schema that avoids the llm_metrics init call for local mode
  • default to using the llm_metrics only if no schema is passed in
  • default to whylabs writer if no writer is passed in

FelipeAdachi
FelipeAdachi approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamie256 jamie256 merged commit ae9fc6d into main Nov 6, 2024
12 checks passed
@jamie256 jamie256 deleted the dev/jamie/rolling_logger_schema branch November 6, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelipeAdachi FelipeAdachi FelipeAdachi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamie256 @FelipeAdachi