Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refac: Add warnings on mismatch between metric and matrix #32

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Refac: Add warnings on mismatch between metric and matrix #32

merged 7 commits into from
Jul 28, 2023

Conversation

murilommen
Copy link
Contributor

When defining a Dataset-level metric, you can't also setup a ColumnMatrix and vice-versa. This was already taken care of by the toolkit, but with two missing things:

  • Segments were lost, even if defined on the specific TargetMatrix
  • Nothing was warned to the user about it

This PR brings both of these to the codebase

@murilommen murilommen temporarily deployed to whylabs-toolkit-ci July 24, 2023 14:43 — with GitHub Actions Inactive
@christinedraper christinedraper self-assigned this Jul 26, 2023
@murilommen murilommen temporarily deployed to whylabs-toolkit-ci July 28, 2023 14:28 — with GitHub Actions Inactive
@murilommen murilommen merged commit 2fa7451 into mainline Jul 28, 2023
1 check passed
@murilommen murilommen deleted the dev/murilommen/warn-on-wrong-metrics-target branch July 28, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-rogers richard-rogers richard-rogers left review comments

@christinedraper christinedraper christinedraper approved these changes

Assignees

@christinedraper christinedraper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murilommen @christinedraper @richard-rogers