Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refac: Unit tests #34

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Refac: Unit tests #34

merged 7 commits into from
Jul 28, 2023

Conversation

murilommen
Copy link
Contributor

@murilommen murilommen commented Jul 27, 2023

Bringing in a bunch of refactors to the codebase, such as:

  • make get type methods return None instead of raising exceptions
  • testing previously untested methods
  • refactor unit tests
  • refactor monitor helpers
  • make all helpers work with the default Config variables (a.k.a. making all org_id and dataset_id optional)

@murilommen murilommen force-pushed the dev/murilommen/refac-unit-tests branch from f678945 to f8b3e1e Compare July 27, 2023 20:38
@murilommen murilommen temporarily deployed to whylabs-toolkit-ci July 27, 2023 20:38 — with GitHub Actions Inactive
whylabs_toolkit/helpers/schema.py Outdated Show resolved Hide resolved
@murilommen murilommen temporarily deployed to whylabs-toolkit-ci July 28, 2023 12:07 — with GitHub Actions Inactive
@murilommen murilommen merged commit f365071 into mainline Jul 28, 2023
1 check passed
@murilommen murilommen deleted the dev/murilommen/refac-unit-tests branch July 28, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants