Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnoser to whylabs-toolkit #59

Merged
merged 14 commits into from
May 3, 2024

Conversation

christinedraper
Copy link
Collaborator

@christinedraper christinedraper commented Apr 22, 2024

Adds toolkit support for the new diagnoser capability in the WhyLabs API.

Also updates some dependencies for issues found when integrating with the diagnoser capabilities:

  • pydantic 1.10.7 caused TypeError: issubclass() arg 1 must be a class
  • typing-extensions 4.5.0 caused ImportError: cannot import name 'Doc' from 'typing_extensions'
  • urllib3 2.0.1 caused large (probably compressed) responses to be truncated

Had to adjust test_create_custom_metric to use metric_name not metric_label when deleting. It's an unavoidable consequence of changing to have proper names - we dont want to delete by label.

Bumping minor version rather than patch for the above because of the slightly breaking change and deps as well as significant new feature.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@christinedraper christinedraper changed the title Draft: Add diagnoser to whylabs-toolkit Add diagnoser to whylabs-toolkit Apr 26, 2024
Copy link
Contributor

@murilommen murilommen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)
PS: remember to use dev0 only on this branch to do dev releases and test it further and then make bump-release before merging it to main

@christinedraper christinedraper merged commit 5e7d121 into mainline May 3, 2024
1 check passed
@christinedraper christinedraper deleted the dev-cd-diagnoser-#86azbk45e branch May 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants