-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnoser to whylabs-toolkit #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinedraper
had a problem deploying
to
whylabs-toolkit-ci
April 22, 2024 21:56
— with
GitHub Actions
Failure
murilommen
reviewed
Apr 22, 2024
christinedraper
had a problem deploying
to
whylabs-toolkit-ci
April 23, 2024 00:34
— with
GitHub Actions
Failure
christinedraper
had a problem deploying
to
whylabs-toolkit-ci
April 23, 2024 13:03
— with
GitHub Actions
Failure
christinedraper
had a problem deploying
to
whylabs-toolkit-ci
April 23, 2024 13:18
— with
GitHub Actions
Failure
christinedraper
had a problem deploying
to
whylabs-toolkit-ci
April 23, 2024 13:21
— with
GitHub Actions
Failure
christinedraper
had a problem deploying
to
whylabs-toolkit-ci
April 26, 2024 20:14
— with
GitHub Actions
Failure
christinedraper
had a problem deploying
to
whylabs-toolkit-ci
April 26, 2024 20:22
— with
GitHub Actions
Failure
christinedraper
changed the title
Draft: Add diagnoser to whylabs-toolkit
Add diagnoser to whylabs-toolkit
Apr 26, 2024
christinedraper
temporarily deployed
to
whylabs-toolkit-ci
April 26, 2024 20:29
— with
GitHub Actions
Inactive
christinedraper
temporarily deployed
to
whylabs-toolkit-ci
April 26, 2024 20:31
— with
GitHub Actions
Inactive
murilommen
reviewed
Apr 29, 2024
murilommen
reviewed
Apr 29, 2024
christinedraper
force-pushed
the
dev-cd-diagnoser-#86azbk45e
branch
from
April 30, 2024 13:58
dacc39b
to
b976eee
Compare
christinedraper
temporarily deployed
to
whylabs-toolkit-ci
April 30, 2024 13:58
— with
GitHub Actions
Inactive
christinedraper
temporarily deployed
to
whylabs-toolkit-ci
April 30, 2024 14:18
— with
GitHub Actions
Inactive
murilommen
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good :)
PS: remember to use dev0 only on this branch to do dev releases and test it further and then make bump-release
before merging it to main
christinedraper
temporarily deployed
to
whylabs-toolkit-ci
May 3, 2024 02:05
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds toolkit support for the new diagnoser capability in the WhyLabs API.
Also updates some dependencies for issues found when integrating with the diagnoser capabilities:
TypeError: issubclass() arg 1 must be a class
ImportError: cannot import name 'Doc' from 'typing_extensions'
Had to adjust test_create_custom_metric to use metric_name not metric_label when deleting. It's an unavoidable consequence of changing to have proper names - we dont want to delete by label.
Bumping minor version rather than patch for the above because of the slightly breaking change and deps as well as significant new feature.