Use the v1 version of the log api #1589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naddeoa
force-pushed
the
log-api-update
branch
from
a74b1cb
to
bc11e6b
Compare
|
Some of the integration tests are failing. Investigating... |
Some just look like the mocks for injecting throttling need to be adjusted for V1. There are also some transaction test failures I haven't looked at yet. |
|
There are integration tests failing on mainline too, so maybe some of this is a backend problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from the v0 to the v1 profile upload api, replacing the previous use of log_async in the whylabs client with log_profile. The apis are functionally the same but the dataset id and the org id are specified differently. The dataset id has to be supplied via a different name and ends up as a header in the request, while the org id is not specified at all because its derived from the api key.
In terms of implementation, I tried to do this all from outside of whylogs to avoid having to make this change but there are several issues that pop up when you try to pass in your own
WhylabsClient, and especially your ownApiClientthat made that impossible. The refactor looks daunting as well.Instead, this change just passes on the
WhylabsClientto the other "sub writers" that are secretly made in the whylabs writer, and hard codes the use of the v1 api over the v0 api.