make dep-map work with non-vendored deps #37
Conversation
For some reason, it was expecting dependencies to be vendored in `vendor/`.
| @@ -108,13 +108,14 @@ var DepMapCommand = cli.Command{ | |||
| Name: "dep-map", | |||
| Usage: "prints out a json dep map for usage by 'import --map'", | |||
| Action: func(c *cli.Context) error { | |||
| pkg, err := LoadPackageFile(gx.PkgFileName) | |||
| var pkg gx.Package | |||
There was a problem hiding this comment.
any particular reason to do this? The base gx.Package type doesnt have the platform specific code in it
There was a problem hiding this comment.
Hm. I believe I thought I needed it to call ForEachDep but that's clearly not the case.
There was a problem hiding this comment.
Ah. Yes, it is because I wanted to use ForEachDep.
- I don't actually use the additional fields.
- I need
buildMapto take agx.Packagebecause that's whatForEachDepspits out.
There was a problem hiding this comment.
If you make buildmap take a gx.PackageBase, then the gx-go Package type can be passed into it just fine.
Either way though, as long as you arent writing out package.json files, or needing the gx fields, it doesnt matter much
There was a problem hiding this comment.
If you make buildmap take a gx.PackageBase, then the gx-go Package type can be passed into it just fine.
Yeah, I'd just rather be consistent. Note: I do need a gx field dvcsImport but I extract that with GxDvcsImport.
For some reason, it was expecting dependencies to be vendored in
vendor/.