Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks: use sh #227

Merged
merged 1 commit into from
Feb 26, 2019
Merged

hooks: use sh #227

merged 1 commit into from
Feb 26, 2019

Conversation

Stebalien
Copy link
Collaborator

We can assume a unix-like shell and it:

  1. Simplifies this code and removes weird corner cases where gx deviates from bash.
  2. Makes it easy to run multiple commands.

@Stebalien
hooks: use sh
1294467 
We can assume a unix-like shell and it:

1. Simplifies this code and removes weird corner cases where gx deviates from bash.
2. Makes it easy to run multiple commands.
@Stebalien Stebalien mentioned this pull request Feb 26, 2019
Open
@Stebalien Stebalien merged commit 00c98e0 into master Feb 26, 2019
@Stebalien Stebalien deleted the feat/use-bash branch February 26, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @raulk