Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more found issues #39

Closed
a-vorobyoff opened this issue Aug 24, 2023 · 1 comment
Closed

Some more found issues #39

a-vorobyoff opened this issue Aug 24, 2023 · 1 comment

Comments

@a-vorobyoff
Copy link

  1. Vite trying to connect with Nuxt on port 24678 for hot reloading code changes – spamming webconsole log and don't work. Need expose in docker-compose.override.yml
    ports:

    • "24678:24678"
  2. Content loading in Nuxt don't work because of Nuxt do request on /api/_content but it routed by traefik on backend instead of frontend.
    I change PathPrefix(/api) to PathPrefix(/api/v) in docker-compose.override.yml of backend setting. Now /api/ will route to frontend.

  3. When trying register with only an email by magic link, it failed:
    File "/app/app/crud/crud_user.py", line 19, in create
    hashed_password=get_password_hash(obj_in.password),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    because password don't exist. Some fix:
    hashed_password=get_password_hash(obj_in.password) if obj_in.password is not None else None,

Hope this help fix some bugs.

@turukawa
Copy link
Member

@a-vorobyoff this is great, thank you :)

You're also welcome to do a pull request, otherwise I'll pull these through myself.

turukawa added a commit that referenced this issue Aug 26, 2023
Fixing [#39](#39):

- Exposing port 24678 for Vite on frontend in development mode.
- Ensuring Nuxt content on `/api/_content` doesn't interfere with backend `/api/v` routes.
- Checking for password before hashing on user creation.
echocraft201315 added a commit to echocraft201315/fastAPI-mongoDB that referenced this issue Mar 27, 2025
Fixing [#39](whythawk/full-stack-fastapi-postgresql#39):

- Exposing port 24678 for Vite on frontend in development mode.
- Ensuring Nuxt content on `/api/_content` doesn't interfere with backend `/api/v` routes.
- Checking for password before hashing on user creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants