codecov improvements

wickedOne · Feb 11, 2024 · 5eebf30 · 5eebf30
1 parent 883f3b5
commit 5eebf30
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/lib/GPH/Psalm.pm b/lib/GPH/Psalm.pm
@@ -81,7 +81,7 @@ sub getConfig {
  ));
  }
 
- if (@{$self->{ignoredDirectories}}) {
+ if (defined $self->{ignoredDirectories}) {
  my $ignoreFiles = $self->{generator}->buildElement('ignoreFiles', undef, $projectFiles);
 
  foreach my $path (@{$self->{ignoredDirectories}}) {
@@ -91,7 +91,7 @@ sub getConfig {
  }
  }
 
- if (@{$self->{plugins}}) {
+ if (defined $self->{plugins}) {
  my $plugins = $self->{generator}->buildElement('plugins', undef, $psalm);
 
  foreach my $plugin (@{$self->{plugins}}) {

diff --git a/t/share/Gitlab/CODEOWNERS b/t/share/Gitlab/CODEOWNERS
@@ -1,6 +1,6 @@
 [alpha]
 /src/Command @teams/alpha
-/src/Service @teams/alpha
+/src/Service @teams/alpha @#!$%^
 .gitlab-ci.yml @teams/alpha
 
 [beta]

diff --git a/t/unit/GPH/PHPStan.t b/t/unit/GPH/PHPStan.t
@@ -45,7 +45,10 @@ describe "class `$CLASS` instantiation values" => sub {
 
  case 'maximum config' => sub {
  @ignoredDirectories = qw(/ignored/);
+ $ignoredDirectories[1] = undef;
+
  @includes = qw(/includes/);
+ $includes[1] = undef;
 
  %config = (
  level => 1,

diff --git a/t/unit/GPH/PHPUnit.t b/t/unit/GPH/PHPUnit.t
@@ -30,7 +30,7 @@ describe "class `$CLASS`" => sub {
  };
 
  tests "baseline file not found" => sub {
- ok(dies{$CLASS->new((codeowners => $CODEOWNERS_FILE, owner =>'@teams/alpha', baseline => 'foo.txt'))}, 'died with codeowners not found') or note ($@);
+ ok(dies{$CLASS->new((codeowners => $CODEOWNERS_FILE, owner =>'@teams/alpha', baseline => 'foo.txt'))}, 'died with baseline not found') or note ($@);
  };
 };