Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InMethod TreeGrid doesn't properly react to clicks after opening a closed subtree #513

Open
duesenklipper opened this issue Jun 7, 2016 · 5 comments

Comments

@duesenklipper
Copy link

When running e.g. the inmethodgrid-examples, newly-displayed rows after opening a closed subtree do not react to clicks. In the demo, neither selecting such items in "Tree Grid with item selection" nor editing such items in "Editable TreeGrid" works.

Workaround: After manually refreshing (F5) the page, it works for those items. Items that are in other subtrees that get opened later need another refresh to work. This is rather awkward for the users.

I suspect that some JavaScript event handlers do not get properly attached by the AJAX response to the click on the "open subtree" icon. I'm investigating it, but it would be great if someone more familiar with this component could have a look too.

@duesenklipper
Copy link
Author

After the Ajax request, the newly visible table rows do not have the onclick-Handler that should be supplied by the AjaxFormSubmitBehavior which is added to each table row by AbstractGrid. I do not yet know why this is, but both in the Chrome debugger and in Firebug I can see that the original table rows have this onclick-handler, the new ones don't.

@duesenklipper
Copy link
Author

Interestingly, it seems only to happen in master. The wicket-6.x branch works correctly. Still investigating.

@duesenklipper
Copy link
Author

duesenklipper commented Jun 8, 2016

I'm still investigating this. I can see that in the the event handlers are not showing up, but in the full page refresh they are there.

I'm trying to git bisect this, but so far that hasn't taken me anywhere. It looks as if this has never worked in the 7.x branch.

@duesenklipper
Copy link
Author

This is related to wicketstuff/wicket1.5-tree#3.

@duesenklipper
Copy link
Author

I found a fix for the bug in wicket1.5-tree (wicketstuff/wicket1.5-tree#4). Once that is accepted and merged, inmethod-grid could be updated. I already tried it locally, it works by simply updating that dependency.

duesenklipper added a commit to duesenklipper/wicketstuff-core that referenced this issue Jun 9, 2016
martin-g added a commit that referenced this issue Jun 9, 2016
…-tree

upgrade to wicket15-tree 7.1.0 to fix issue #513, regression with ope…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant