Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize wiquery or add automatic module name #97

Closed
theigl opened this issue Dec 1, 2024 · 2 comments · Fixed by #98
Closed

Modularize wiquery or add automatic module name #97

theigl opened this issue Dec 1, 2024 · 2 comments · Fixed by #98

Comments

@theigl
Copy link

theigl commented Dec 1, 2024

I'm in the process of modularizing my application and noticed that wiquery currently has neither automatic module name nor module-info:

[WARNING] *****************************************************************************************************************************************************************************
[WARNING] * Required filename-based automodules detected: [wiquery-core-10.0.0.jar, wiquery-jquery-ui-10.0.0.jar]. Please don't publish this project to a public artifact repository! *
[WARNING] *****************************************************************************************************************************************************************************

Should we modularize the project or at least add an automatic module name?

I can provide a PR.

@martin-g
Copy link
Member

martin-g commented Dec 1, 2024

+1
whatever is easier for you

@theigl
Copy link
Author

theigl commented Dec 2, 2024

I attempted to modularize the project but the UI module depends on the test-jar of the core module. It is non-trivial to support this setup in a modularized project. Most likely, we would have to introduce a new wiquery-test module that both core and UI depend on.

For now, I just went with an automatic module name.

martin-g added a commit that referenced this issue Dec 2, 2024
#97 Add automatic module name for core and UI modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants