Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work/xthiba/changes #32

Merged
merged 11 commits into from
Mar 5, 2024
Merged

Conversation

xthiba
Copy link

@xthiba xthiba commented Mar 1, 2024

first stab at some contribution.

Thanks for keeping wiquery alive.

Let me know what you think!

@xthiba xthiba mentioned this pull request Mar 1, 2024
Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xthiba
Copy link
Author

xthiba commented Mar 4, 2024

i can see the build failure is due to me being on java 17...
https://stackoverflow.com/questions/55955641/correct-locale-for-indonesia-id-id-vs-in-id
I'll try to come up with a better solution to this backwards compatability issue.

@martin-g
Copy link
Member

martin-g commented Mar 4, 2024

@xthiba
Copy link
Author

xthiba commented Mar 4, 2024

thanks for the pointer 💯

feel free to merge if build passes. should we add a java17 build now, or wait for 10.x?

@martin-g martin-g merged commit b03b6c7 into wicketstuff:master Mar 5, 2024
1 check passed
@martin-g
Copy link
Member

martin-g commented Mar 5, 2024

feel free to merge if build passes. should we add a java17 build now, or wait for 10.x?

Are you a colleague of @renoth ?
He recently asked for a Wicket 10 release at #9

@xthiba xthiba deleted the work/xthiba/changes branch March 5, 2024 09:06
@xthiba
Copy link
Author

xthiba commented Mar 5, 2024

Are you a colleague of @renoth ? He recently asked for a Wicket 10 release at #9

No, not that i know of at least ;-)
but we would be interested in a wicket 10 release as well, and may look into it sometime in the future (no commitment yet, though)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants