Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Wicket 10 / Jakarta EE 10 #35

Merged
merged 3 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v4
with:
java-version: 11
java-version: 17
distribution: temurin

- name: Cache Local Maven Repository
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ WiQuery consists of 3 subprojects:
WiQuery requires the following:

- Java 8
- Servlet 3.1
- Wicket 8.0 or newer
- Servlet 5.0
- Wicket 10 or newer

Newer or older major releases of Wicket are not compatible with this version of WiQuery.

Expand Down
9 changes: 4 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<groupId>org.wicketstuff.wiquery</groupId>
<artifactId>wiquery-parent</artifactId>
<packaging>pom</packaging>
<version>9.1.0-SNAPSHOT</version>
<version>10.0.0-M2-SNAPSHOT</version>
<name>WiQuery Parent</name>

<licenses>
Expand Down Expand Up @@ -60,12 +60,12 @@
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.source>11</maven.compiler.source>

<wicket.version>9.16.0</wicket.version>
<wicket.version>10.0.0-M2</wicket.version>
<jackson.version>2.16.1</jackson.version>
<slf4j.version>2.0.12</slf4j.version>
<junit.version>5.10.2</junit.version>
<servlet-api.version>4.0.4</servlet-api.version>
<jetty.version>9.4.54.v20240208</jetty.version>
<servlet-api.version>5.0.0</servlet-api.version>
<jetty.version>11.0.20</jetty.version>
<rhino.version>1.7.14</rhino.version>
</properties>

Expand Down Expand Up @@ -303,7 +303,6 @@
<version>3.6.3</version>
<configuration>
<encoding>UTF-8</encoding>
<additionalparam>-Xdoclint:none</additionalparam>
</configuration>
</plugin>
<plugin>
Expand Down
9 changes: 8 additions & 1 deletion wiquery-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.wicketstuff.wiquery</groupId>
<artifactId>wiquery-parent</artifactId>
<version>9.1.0-SNAPSHOT</version>
<version>10.0.0-M2-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wiquery-core</artifactId>
Expand All @@ -22,6 +22,13 @@
</dependency>

<!-- Test dependencies -->
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-tester</artifactId>
<version>${wicket.version}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static ResourceReference getJQueryResourceReference()
}
else
{
reference = JQueryResourceReference.getV1();
reference = JQueryResourceReference.getV3();
}
return reference;
}
Expand Down
18 changes: 13 additions & 5 deletions wiquery-demo/pom.xml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<artifactId>wiquery-parent</artifactId>
<groupId>org.wicketstuff.wiquery</groupId>
<version>9.1.0-SNAPSHOT</version>
<version>10.0.0-M2-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand All @@ -25,6 +26,12 @@
</dependency>

<!-- Test dependencies -->
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-tester</artifactId>
<version>${wicket.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
Expand All @@ -44,13 +51,14 @@
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-plus</artifactId>
<artifactId>jetty-server</artifactId>
<version>${jetty.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>jakarta.servlet</groupId>
<artifactId>jakarta.servlet-api</artifactId>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-webapp</artifactId>
<version>${jetty.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ public static void main(String[] args)
ServerConnector connector = new ServerConnector(server, new HttpConnectionFactory());
// Set some timeout options to make debugging easier.
connector.setIdleTimeout(1000 * 60 * 60);
connector.setSoLingerTime(-1);
connector.setPort(8080);
server.setConnectors(new Connector[] { connector });

Expand Down
8 changes: 7 additions & 1 deletion wiquery-jquery-ui/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.wicketstuff.wiquery</groupId>
<artifactId>wiquery-parent</artifactId>
<version>9.1.0-SNAPSHOT</version>
<version>10.0.0-M2-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wiquery-jquery-ui</artifactId>
Expand All @@ -31,6 +31,12 @@
</dependency>

<!-- Test dependencies -->
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-tester</artifactId>
<version>${wicket.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
Expand Down