Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] state/rds-aurora-serverless - Update supported versions #695

Merged
merged 1 commit into from
Jul 5, 2023
Merged

[Improvement] state/rds-aurora-serverless - Update supported versions #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions state/rds-aurora-serverless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,17 +138,13 @@ Parameters:
EngineVersion:
Description: 'Aurora Serverless MySQL version.'
Type: String
AllowedValues: ['5.7.mysql-aurora.2.08.3', '5.6.mysql-aurora.1.22.3'] # aws rds describe-db-engine-versions --engine aurora --query 'DBEngineVersions[?contains(SupportedEngineModes,`serverless`)].EngineVersion'; aws rds describe-db-engine-versions --engine aurora-mysql --query 'DBEngineVersions[?contains(SupportedEngineModes,`serverless`)].EngineVersion'
AllowedValues: ['5.7.mysql-aurora.2.08.3'] # aws rds describe-db-engine-versions --engine aurora-mysql --query 'DBEngineVersions[?contains(SupportedEngineModes,`serverless`)].EngineVersion'
Mappings:
EngineVersionMap:
'5.7.mysql-aurora.2.08.3':
ClusterParameterGroupFamily: 'aurora-mysql5.7'
EngineVersion: '5.7.mysql_aurora.2.08.3'
Engine: 'aurora-mysql'
'5.6.mysql-aurora.1.22.3':
ClusterParameterGroupFamily: 'aurora5.6'
EngineVersion: '5.6.mysql_aurora.1.22.3'
Engine: aurora
Conditions:
HasSecret: !Not [!Equals [!Ref ParentSecretStack, '']]
HasZone: !Not [!Equals [!Ref ParentZoneStack, '']]
Expand Down
8 changes: 2 additions & 6 deletions test/src/test/java/de/widdix/awscftemplates/state/TestRDSAuroraServerless.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,11 @@

public class TestRDSAuroraServerless extends ACloudFormationTest {

@Test
public void testVersion56() {
this.testVersion("5.6.mysql-aurora.1.22.3");
}

@Test
public void testVersion57() {
this.testVersion("5.7.mysql-aurora.2.08.3");
}

private void testVersion(final String version) {
final Context context = new Context();
final String vpcStackName = "vpc-2azs-" + this.random8String();
Expand Down Expand Up @@ -84,7 +80,7 @@ public void testWithSecret() {
new Parameter().withParameterKey("ParentKmsKeyStack").withParameterValue(kmsKeyStackName),
new Parameter().withParameterKey("ParentSecretStack").withParameterValue(secretStackName),
new Parameter().withParameterKey("DBName").withParameterValue("db1"),
new Parameter().withParameterKey("EngineVersion").withParameterValue("5.6.mysql-aurora.1.22.3")
new Parameter().withParameterKey("EngineVersion").withParameterValue("5.7.mysql-aurora.2.08.3")
);
// TODO how can we check if this stack works? start a bastion host and try to connect?
} finally {
Expand Down