-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 373 #375
Merged
Merged
Issue 373 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unpinned SQLAlchemy so that Python 3.9 can be used. Updated makefile to use -o and --run_id arguments in new CLI.
This should not ever have more than one value as files will just be overwritten.
I am less familiar with how this should work, and therefore this file probably requires more scrutiny.
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 75.35% 75.40% +0.04%
==========================================
Files 52 52
Lines 3421 3431 +10
==========================================
+ Hits 2578 2587 +9
- Misses 843 844 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial PR fixes a number of niggling bugs that we needed to clear, before tackling #373 directly.
Due to scheduling/planning, we decided to make PR/merge of these smaller changes now, and merge the
fastANI
branch (after rebasing tomaster
) at this point, so that we could consolidate the associated database changes forfastANI
across branches.This branch will remain live for fixing #340 after this PR/merge
Type of change
Action Checklist
pyani
repository under your own account (please allow write access for repository maintainers)CONTRIBUTING.md
)pytest -v
non-passing code will not be mergedorigin/master
flake8
andblack
before submissionPull requests
section in thepyani
repository