fix: theme initialisation with Voilà lab template #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
master
branch
3 times, most recently
from
368ca6d
to
e241012
Compare
maartenbreddels
force-pushed
the
master
branch
5 times, most recently
from
0017486
to
f4937c0
Compare
guimillet
force-pushed
the
auto-theme-voila
branch
from
8616add
to
23a225e
Compare
reintroduced changes of the previous commit, which was discarded upon updating the branch to master due to merging conlicts
reintroduced changes of the previous commit (6 Dec 2021), which was discarded upon updating the branch to master due to merging conflicts
double-quote format
|
I messed up the push by merging the branch after having discarded the initial commit in the branch for updating the branch to current master... |
|
The test build failed with this error: UserWarning: ValueError: Extensions require a devDependency on @jupyterlab/builder@^4.0.4, you have a dependency on 3.0.0. The test workflow requires jupyterlab<4 as in commit 1095abecd4cc18977067013a18a8ad0b7adcf35d. |
|
The build issue on master is now fixed, if you update it will build. |
mariobuikhuizen
approved these changes
Aug 23, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class names of the document's body's are checked whether they
contain 'theme-light' or 'theme-dark', which indicates the theme loaded
by Voilà for the lab template.
The patch also adds 'dark_jlab' attribute to know the inherited theme in JLab.
Resolves: #135