fix: close kernels on shutdown of asgi/starlette server #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Flask does not have lifecycle management, we cannot do the same for Flask. We could implement this for Flask by listening to signals, but that's not the responsibility of the solara server.
maartenbreddels
temporarily deployed
to
fix_close_kernels_on_shutdown - solara-stable PR #930
Render
Destroyed
iisakkirotko
approved these changes
Dec 16, 2024
| try: | ||
| context.close() | ||
| except: # noqa | ||
| logger.exception("error closing kernel on shutdown") |
There was a problem hiding this comment.
Would it be useful to identify which kernel's shutdown failed for logging purposes?
There was a problem hiding this comment.
I don't think the ID gives much information, but this will show the stacktrace, which should give a hint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Flask does not have lifecycle management, we cannot do the same for Flask.
We could implement this for Flask by listening to signals, but that's not the responsibility of the solara server.
Fixes #929