Rebase: Ship Formatting Updates #359
Open
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the extendedLabels, have ships that have destination information display like aircraft.
Populate callsign / registration with mmsi if either is blank. Non-ship ais objects may not have a callsign. mmsi is a unique identifier and can be used for filtering.
wiedehopf
reviewed
Jan 30, 2025
wiedehopf
reviewed
Jan 30, 2025
rbollar
commented
Jan 30, 2025
There was a problem hiding this comment.
No worries on the mmsi -- I was trying to fix the situation that aids to navigation don't have callsigns and sometimes don't broadcast registrations. Would you consider a substitution of mmsi for registration like we did for callsigns in planeObject.js? Or should I just let it go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add destination to callsign when available to make ais extended labels look like adsb. I think at this point ship / air extended labels look fairly harmonized.
Add shiptype = 0 with value UNKN for ships that don't report a shiptype -- more likely than deliberately using a reserved value.
Replace blank callsign / registration with MMSI. Since non-ships don't have a callsign & may not have a registration, this gives them a unique identifier.